Skip to content

Conversation

@rishabhmalikMS
Copy link
Contributor

@rishabhmalikMS rishabhmalikMS commented Oct 16, 2025

Context

This PR addresses a race condition in ProcessInvoker.CancelAndKillProcessTree that causes InvalidOperationException ("No process is associated with this object") crashes in production.
📌 AB#2326727


Description

Removes risky process property access from trace logging statements in ProcessInvoker to eliminate race conditions. The changes include:


Risk Assessment (Low / Medium / High)

Low Risk - This is a surgical fix that only removes non-essential logging statements. Core process execution functionality remains unchanged. The changes eliminate a known crash scenario without introducing new code paths or complex logic.


Unit Tests Added or Updated (Yes / No)

No


Additional Testing Performed

List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).


Change Behind Feature Flag (Yes / No)

No


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

@rishabhmalikMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rishabhmalikMS rishabhmalikMS changed the title Reverting process invoker logs to not log proc object attributes Reverting process invoker logs Oct 16, 2025
@rishabhmalikMS rishabhmalikMS marked this pull request as ready for review October 16, 2025 07:41
@rishabhmalikMS rishabhmalikMS requested review from a team as code owners October 16, 2025 07:41
@rishabhmalikMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rishabhmalikMS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rishabhmalikMS rishabhmalikMS merged commit 9d94073 into master Oct 17, 2025
22 checks passed
@rishabhmalikMS rishabhmalikMS deleted the users/rishabhmalikMS/processinvokerLogsRevert branch October 17, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants