Skip to content

Notifications are also enabled when a pull request is opened and the pipeline is triggered manually. #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

Notifications are also enabled when a pull request is opened and the pipeline is triggered manually. #5386

merged 3 commits into from
Nov 6, 2025

Conversation

@raujaiswal
Copy link
Contributor

@raujaiswal raujaiswal commented Nov 6, 2025 •
edited
Loading

Context

Notifications are also enabled when a pull request is opened, and the pipeline is triggered manually

Description

Provide a concise summary of the changes introduced in this PR.

Risk Assessment (Low / Medium / High)

Assess the risk level and justify your assessment. For example: code path sensitivity, usage scope, or backward compatibility concerns.

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect the changes.

Additional Testing Performed

List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).

Change Behind Feature Flag (Yes / No)

Can this change be behine feature flag, if not why?

Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

@raujaiswal raujaiswal requested review from a team as code owners November 6, 2025 06:15
@raujaiswal raujaiswal changed the title Users/raujaiswal ms/localization Notifications are also enabled when a pull request is opened and the pipeline is triggered manually. Nov 6, 2025
@raujaiswal raujaiswal merged commit 3919ccc into Localization Nov 6, 2025
1 of 2 checks passed
@raujaiswal raujaiswal deleted the users/raujaiswalMS/localization branch November 6, 2025 06:19
raujaiswal added a commit that referenced this pull request Nov 18, 2025
@raujaiswal @denis-tikhomirov
@vmapetr @csigs
Localization update (#5401)
33a9b8a 
* Move notifications about Agent Localization PR from Slack to MS Teams - Part 1 (#3744)

* Include strings from Misc/src/layoutbin to LocProject file (#4021)

* Update LocProject file

* Update CopyOption for LocProject

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 18665127 (#4022)

* Revert "Include strings from Misc/src/layoutbin to LocProject file (#4021)"

This reverts commit 8f5c0c0.

* Revert "Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 18665127 (#4022)" (#4023)

This reverts commit b9c714b.

* Include layoutbin into locproject

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 18680899 (#4028)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20221104175414554. (#4030)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20221105085259861. (#4031)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20221106085521421. (#4032)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 18697046 (#4033)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20221107143113520. (#4039)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 18706620 (#4044)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19415018 (#4163)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230223095051399. (#4168)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230224095040576. (#4170)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19476421 (#4179)

* Update loc strings

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19476736 (#4181)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230305095015478. (#4183)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230306095225210. (#4184)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19485674 (#4186)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19909232 (#4273)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230516085151802. (#4277)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230517085117344. (#4279)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 19991094 (#4290)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230525085047495. (#4294)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 20060830 (#4298)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230530085158885. (#4300)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 20130640 (#4308)

* Resolve merge conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 20695729 (#4361)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230720084945943. (#4366)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 20860135 (#4376)

* Resolve conflicts

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230830084958251. (#4411)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20230831085154349. (#4413)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 22418179 (#4436)

* Resolve conflicts

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20231018085617238. (#4475)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20231019085845419. (#4478)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 22996954 (#4487)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20231025085014565. (#4490)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 23093000 (#4496)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20231202100120218. (#4550)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 24315652 (#4551)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 26275354 (#4632)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240207095200103. (#4637)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 26578360 (#4645)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240208095320656. (#4639)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240210140634450. (#4643)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 26582349 (#4647)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240213095043949. (#4651)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 26605634 (#4654)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240214140615474. (#4661)

Co-authored-by: Maksim Petrov <[email protected]>

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 26778087 (#4668)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 27387363 (#4720)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240322085123308. (#4727)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240321085632376. (#4724)

Co-authored-by: Maksim Petrov <[email protected]>

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 27580751 (#4739)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28506303 (#4832)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28618189 (#4844)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240609090301673. (#4835)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240610090926416. (#4837)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28618318 (#4846)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240616085747611. (#4848)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28695504 (#4853)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28724274 (#4865)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240625104508567. (#4867)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240626090031966. (#4869)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28737791 (#4870)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240627093147135. (#4874)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28741926 (#4876)

* Resolve conflicts

* Update loc yaml

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28877864 (#4908)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 28991852 (#4957)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20240828085148703. (#4964)

* Resolve conflicts

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 29002811 (#4966)

* Resolve conflicts

* Bump OneLoc task version

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30590809 (#5349)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20250101143802868. (#5077)

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20251105171532653. (#5374)

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30681548 (#5375)

* disabling source branch deletion (#5376)

Co-authored-by: azure-pipelines-bot <[email protected]>

* Revert "Localized file check-in by OneLocBuild Task: Build definition ID 1094…" (#5377)

This reverts commit 0684f75.

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30681572 (#5379)

* Revert "Localized file check-in by OneLocBuild Task: Build definition ID 1094…" (#5380)

This reverts commit 8010bc2.

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30681585 (#5381)

* Revert "Localized file check-in by OneLocBuild Task: Build definition ID 1094…" (#5383)

This reverts commit 57fb75c.

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30681665 (#5384)

* Revert "Localized file check-in by OneLocBuild Task: Build definition ID 1094…" (#5387)

This reverts commit c487ae4.

* Notifications are also enabled when a pull request is opened and the pipeline is triggered manually. (#5386)

* disabling source branch deletion

* Notifications are  also enabled when a pull request is opened and the pipeline is triggered manually.

---------

Co-authored-by: azure-pipelines-bot <[email protected]>

* Localized file check-in by OneLocBuild Task: Build definition ID 10944: Build ID 30681911 (#5389)

* updated alert notification for failed pipeline (#5391)

* disabling source branch deletion

* Notifications are  also enabled when a pull request is opened and the pipeline is triggered manually.

* updated alert notification for failed pipeline

---------

Co-authored-by: azure-pipelines-bot <[email protected]>

* Juno: check in to lego/hb_5733438c-38c5-41ae-9557-a9d9754c4535_20251111094743893. (#5395)

* Removing Localize and OneLocBuild folder

---------

Co-authored-by: anatolybolshakov <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: KonstantinTyukalov <[email protected]>
Co-authored-by: vmapetr <[email protected]>
Co-authored-by: Maksim Petrov <[email protected]>
Co-authored-by: Alex Hsu <[email protected]>
Co-authored-by: azure-pipelines-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raujaiswal