Disabled Node24 download for linux-armv7l #5393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rishabhmalikMS
approved these changes
Nov 10, 2025
tarunramsinghani
approved these changes
Nov 10, 2025
rajmishra1997
approved these changes
Nov 10, 2025
Contributor
rajmishra1997
left a comment
rajmishra1997
left a comment
There was a problem hiding this comment.
Looks Good, PR context was helpful while review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes a build failure that occurs when building the Azure Pipelines Agent for the
linux-arm(ARMv7l/32-bit ARM) platform. The build was failing during the externals download phase because the script was attempting to download Node.js 24.10.0 for ARMv7l architecture, which does not exist in the official Node.js distribution.Root Cause: Node.js dropped ARMv7l (32-bit ARM) support after version 20.x. The
externals.shscript was unconditionally attempting to download Node 24 for all Linux architectures, includinglinux-arm(ARMv7l).https://nodejs.org/en/blog/migrations/v22-to-v24#platform-support
https://nodejs.org/dist/v24.10.0/
https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list
AB#2324534
Description
Added conditional logic to skip Node.js 24 download for
linux-arm(ARMv7l) platforms in theexternals.shscriptRisk Assessment: Low
Justification:
linux-arm(ARMv7l) platform builds only; no impact on other platforms (x64, arm64, Windows, macOS)Unit Tests Added or Updated: No
Additional Testing Performed
NA
Change Behind Feature Flag: No
NA
Tech Design / Approach
NA
Documentation Changes Required: No
Logging Added/Updated: No
Telemetry Added/Updated: No
Rollback Scenario and Process: NA
Dependency Impact Assessed and Regression Tested: NA