feat: Network module changes and fix

[Abdul-Microsoft]

Purpose

This pull request introduces several improvements and standardizations to the infrastructure codebase, focusing on parameter naming consistency, enhanced deployment configuration, and resource naming conventions. The changes affect both parameter files and Bicep modules, aiming to improve maintainability and clarity across the deployment templates.

Parameter and Naming Standardization:

• Renamed the environmentName parameter to solutionName in both infra/main.parameters.json and infra/main.waf.parameters.json for consistency across deployment parameter files. [1] [2]
• Renamed the parameter file from main.parameters.waf.json to main.waf.parameters.json for improved clarity and organization.

Deployment Configuration Enhancements:

• Added new parameters to infra/main.waf.parameters.json to support monitoring, scalability, and VM administration, including existingFoundryProjectResourceId, enableMonitoring, enableScalability, virtualMachineAdminUsername, and virtualMachineAdminPassword. Also standardized boolean values to unquoted true.

Resource Naming and Convention Updates:

• Updated resource module names in Bicep files (container-registry.bicep, key-vault.bicep, log-analytics-workspace.bicep) to use the take function for generating deterministic, length-constrained names, improving ARM template deployment reliability. [1] [2] [3]
• Standardized subnet and NSG names in virtualNetwork.bicep to lowercase (containers, nsg-containers) to maintain naming consistency and avoid potential case-sensitivity issues.

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[github-actions]

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀