fix: Dev to main merge #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entions, and remove deprecated files
…ventions in virtual network module
feat: Network module changes and fix
…lly apply based on monitoring enablement
…ames for clarity and consistency
fix: Optimize Network Module Deployment & Apply WAF Standardization fixes
fix: Adding condition to keyvault diagnostic settings
chore: Add AZURE_DEV_COLLECT_TELEMETRY in azure-dev.yml file
Dhruvkumar-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prajwal-Microsoft
approved these changes
Oct 20, 2025
Roopan-Microsoft
approved these changes
Oct 20, 2025
Prajwal-Microsoft
added a commit
that referenced
this pull request
Oct 21, 2025
Merge pull request #292 from microsoft/dev
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on standardizing Azure resource naming, environment variable usage, and deployment parameters throughout the codebase. It also improves post-deployment feedback and updates documentation for clarity. The changes are primarily in CI/CD workflow files, infrastructure templates, and documentation.
CI/CD Workflow Improvements and Environment Variable Updates:
deploy.yml,test-automation.yml, etc.) to useAZURE_CLIENT_ID,AZURE_CLIENT_SECRET, andAZURE_SUBSCRIPTION_IDinstead of the previous maintenance-specific variables, ensuring consistency and simplifying secret management. [1] [2] [3] [4]AZURE_DEV_COLLECT_TELEMETRYvariable to the Azure Dev workflow for improved telemetry control.Infrastructure Template and Parameter Standardization:
environmentNametosolutionNameand fromaiDeploymentsLocationtoaiServiceLocationin both main and WAF parameter files, aligning with updated naming conventions. [1] [2] [3] [4] [5]main.waf.parameters.json) to include new fields for monitoring, scalability, and VM credentials.Infrastructure Module Improvements:
takefunction for length-limited, standardized naming, improving resource traceability and compliance. [1] [2] [3]Post-Deployment Feedback Enhancement:
azure.yamlto display detailed web and API app information, including endpoints and Azure portal links, for both POSIX and Windows environments.Documentation Updates:
ConfigureAppAuthentication.mdto reflect new resource naming conventions (ca-<randomname>-webandca-<randomname>-api), ensuring documentation matches deployment outputs. [1] [2] [3] [4] [5] [6]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information