fix: Prevent removal of existing RG tags when deploying GSA #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the tagging logic and resource dependencies in the infrastructure templates to improve tag merging and ensure correct deployment order. The most significant changes involve how tags are applied to resources and the order of dependencies for private DNS zones.
Tagging logic improvements:
resourceGroupTagsresource inmain.bicepnow merges both existing resource group tags and custom tags, ensuring all relevant tags are included when deploying resources.main.jsonARM template updates thetagsproperty to use ashallowMergeof resource group tags, user-supplied tags, and required template tags, providing a more comprehensive and flexible tagging strategy.Resource dependency order corrections:
dependsOnarrays for certain resources inmain.jsonhave been reordered to ensure that private DNS zones foropenAIandcognitiveServicesare created in the correct sequence, which can help prevent deployment issues related to resource readiness.Other changes:
main.jsonwas updated to reflect the changes in the template.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information