Avoid unnecessary/buggy readHead access during command processing #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prvyk
force-pushed
the
parsingimprov
branch
4 times, most recently
from
566175f to
a642573
Compare
TalZaccai
reviewed
Aug 15, 2025
Contributor
TalZaccai
left a comment
TalZaccai
left a comment
There was a problem hiding this comment.
Great changes! Added one comment
…dHead and direct input parsing.
…sRead calculation.
Format fix
TalZaccai
approved these changes
Aug 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes to avoid access to bytesRead, readHead or direct parsing during command parsing after the RespCommand is decided and parseState is set:
ListReadKeysWithCount() in TxnKeyManager doesn't need to reparse the input. It has all required information already in respSession.parseState variable. We can then erase GetCommandAsArgSlice() as it's no longer necessary.
MakeUpperCase() in RespServerSession used bytesRead - readHead for length. Which is wrong when called from GetOperationDirection(). There the actual length is only the argSlice length which is usually far smaller. This accidentally works for typical inputs (probably fails for crafted inputs), fix it by supplying the actual length.
(Both of these are from #1278, but are logically independent fixes we can push separately).