-
Notifications
You must be signed in to change notification settings - Fork 287
adds support for overlays #6753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kilifu
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
kilifu:Feat/add-overlays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7baa30f
add overlays option
kilifu a1f6e9d
caching overlay seams ok
kilifu 7878482
cleanup
kilifu 2d4160e
merge from main
kilifu 5cf8682
ad d BinkyLabs.OpenApi.Overlays
kilifu 5df7c2e
chore: fixes nullable information
baywet 7a3c003
chore: makes a copy of the overlays hashset when cloning
baywet 695e5d0
chore: removes extraneous import
baywet d475ceb
chore: removes extraneous method
baywet 0906247
uniformisation
kilifu 6a17845
Merge branch 'main' into Feat/add-overlays
kilifu 42d3812
updqte binkyLabs nugget
kilifu e9342a9
fix test
kilifu 93623bb
test mutliple overlays
kilifu c928465
Merge branch 'main' into Feat/add-overlays
baywet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,11 +1,15 @@ | ||||||
| using System; | ||||||
| using System.Diagnostics; | ||||||
| using System.IO; | ||||||
| using System.Linq; | ||||||
| using System.Net.Http; | ||||||
| using System.Reflection.Metadata; | ||||||
baywet marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| using System.Security; | ||||||
| using System.Threading; | ||||||
| using System.Threading.Tasks; | ||||||
| using AsyncKeyedLock; | ||||||
| using BinkyLabs.OpenApi.Overlays; | ||||||
| using BinkyLabs.OpenApi.Overlays.Reader; | ||||||
| using Kiota.Builder.Caching; | ||||||
| using Kiota.Builder.Configuration; | ||||||
| using Kiota.Builder.Extensions; | ||||||
|
|
@@ -96,7 +100,7 @@ ex is SecurityException || | |||||
| return (input, isDescriptionFromWorkspaceCopy); | ||||||
| } | ||||||
|
|
||||||
| internal async Task<ReadResult?> GetDocumentWithResultFromStreamAsync(Stream input, GenerationConfiguration config, bool generating = false, CancellationToken cancellationToken = default) | ||||||
| internal async Task<Microsoft.OpenApi.Reader.ReadResult?> GetDocumentWithResultFromStreamAsync(Stream input, GenerationConfiguration config, bool generating = false, CancellationToken cancellationToken = default) | ||||||
| { | ||||||
| var stopwatch = new Stopwatch(); | ||||||
| stopwatch.Start(); | ||||||
|
|
@@ -122,9 +126,9 @@ ex is SecurityException || | |||||
| if (addPluginsExtensions) | ||||||
| settings.AddPluginsExtensions();// Add all extensions for plugins | ||||||
|
|
||||||
| var rawUri = config.OpenAPIFilePath.TrimEnd(KiotaBuilder.ForwardSlash); | ||||||
| try | ||||||
| { | ||||||
| var rawUri = config.OpenAPIFilePath.TrimEnd(KiotaBuilder.ForwardSlash); | ||||||
| var lastSlashIndex = rawUri.LastIndexOf(KiotaBuilder.ForwardSlash); | ||||||
| if (lastSlashIndex < 0) | ||||||
| lastSlashIndex = rawUri.Length - 1; | ||||||
|
|
@@ -137,7 +141,82 @@ ex is SecurityException || | |||||
| { | ||||||
| // couldn't parse the URL, it's probably a local file | ||||||
| } | ||||||
| var readResult = await OpenApiDocument.LoadAsync(input, settings: settings, cancellationToken: cancellationToken).ConfigureAwait(false); | ||||||
|
|
||||||
| Microsoft.OpenApi.Reader.ReadResult readResult = new Microsoft.OpenApi.Reader.ReadResult() { }; | ||||||
| if (config.Overlays.Count != 0) | ||||||
| { | ||||||
| // TODO : handle multiple Overlays | ||||||
| var overlay = config.Overlays.First(); | ||||||
|
||||||
| // TODO : handle multiple Overlays | |
| var overlay = config.Overlays.First(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clone method assigns the same
Overlaysinstance rather than copying it. Change toOverlays = Overlays.ToHashSet(StringComparer.OrdinalIgnoreCase)to avoid shared mutable state.