Ruigao/fix no dns local storage #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes DNS resolution errors in the cluster local storage service by implementing hostname-to-IP mapping from a configuration file. The changes allow the service to resolve hostnames to IP addresses directly, avoiding DNS lookup failures.
- Added hostname-to-IP mapping functionality using the pai-cluster-config layout file
- Modified all SSH commands to use IP addresses instead of hostnames when available
- Mounted the pai-configuration configMap to provide access to the layout configuration
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cluster-local-storage/src/service.py | Implements hostname-to-IP mapping and modifies SSH commands to use resolved IPs |
| src/cluster-local-storage/deploy/cluster-local-storage.yaml.template | Adds volume mount for pai-configuration configMap to access layout file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy pai-config to cluster local storage docker image to avoid DNS error