set externalTrafficPolicy for Pylon and SSH service #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of sysnodepool
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the network routing for Pylon and SSH services by configuring externalTrafficPolicy: Local on their LoadBalancer services. Since these services run exclusively on the paimaster node, this change prevents unnecessary routing through worker nodes, improving performance and reducing latency.
Key changes:
- Added
externalTrafficPolicy: Localto SSH proxy LoadBalancer service configuration - Added
externalTrafficPolicy: Localto Pylon LoadBalancer service configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ssh-proxy/deploy/ssh-proxy.yaml.template | Added externalTrafficPolicy configuration to optimize SSH service routing |
| src/pylon/deploy/pylon-service.yaml | Added externalTrafficPolicy configuration to optimize Pylon service routing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zhogu
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of externalTrafficPolicy setting of load balancer for Pylon and SSH is Cluster, which means that the requests will send to either paimaster node or sysnodepool nodes. Since both of the services are running only on paimaster node, it may bring performance issues. In this PR, we set the value of externalTrafficPolicy to Local so the requests will be sent to paimaster directly.