-
Notifications
You must be signed in to change notification settings - Fork 1
enable imagelist argument for image build script #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ def load_build_config(config_dir): | |
|
|
||
|
|
||
| def build_service(args, config_model): | ||
| pai_build = build_center.BuildCenter(config_model, args.service, 'k8s') | ||
| pai_build = build_center.BuildCenter(config_model, args.service, 'k8s', args) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not args.imagelist directly? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is reserved for possible update which may use other args. |
||
| pai_build.set_build_cache_type(args.nocache) | ||
| pai_build.build_center() | ||
|
|
||
|
|
@@ -98,6 +98,12 @@ def main(): | |
| action='store_true', | ||
| help="Build the service using cache or not" | ||
| ) | ||
| build_parser.add_argument( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can this args be used when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, the push has -i option to push a single image to the server. |
||
| '-i', '--imagelist', | ||
| type=str, | ||
| nargs='+', | ||
| help="The image list you want to build" | ||
| ) | ||
| build_parser.set_defaults(func=build_service) | ||
|
|
||
| # Push commands | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.