Skip to content

Integrate MSCCL++ DSL to torch workload #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 133 commits into from
Oct 29, 2025
Merged

Integrate MSCCL++ DSL to torch workload #620

merged 133 commits into from
Oct 29, 2025

Conversation

@Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented Aug 26, 2025 •
edited
Loading

Provides two integration ways for MSCCL++ DSL.

  1. Integrate with customized communication group
  2. Integrate with NCCL API

Introduce new Python APIs to make it work:

mscclpp.compile # compile dsl to json based execution plan
mscclpp.ExecutionPlanRegistry.register_plan(plan) # register the compiled plan to executionPlanRegistery
mscclpp.ExecutionPlanRegistry.set_selector(selector) # set the selector, the selector will return the best execution plan based on collection, message size, world size....

Fix #556

@Binyang2014
Copy link
Contributor Author

/azp run

@Binyang2014 Binyang2014 requested a review from chhwang October 27, 2025 23:02
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Binyang2014
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Binyang2014 Binyang2014 changed the title MSCCL++ DSL Integration plan Integration MSCCL++ DSL to torch workload Oct 27, 2025
@Binyang2014 Binyang2014 changed the title Integration MSCCL++ DSL to torch workload Integrate MSCCL++ DSL to torch workload Oct 27, 2025
Copilot AI reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 47 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Binyang2014
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

chhwang
chhwang approved these changes Oct 28, 2025
View reviewed changes
@Binyang2014
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@caiomcbr caiomcbr merged commit 5acac93 into main Oct 29, 2025
14 checks passed
@caiomcbr caiomcbr deleted the binyli/py-api branch October 29, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chhwang chhwang chhwang approved these changes

@caiomcbr caiomcbr Awaiting requested review from caiomcbr

@seagater seagater Awaiting requested review from seagater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Flexible selection logic of execution plans

4 participants

@Binyang2014 @chhwang @caiomcbr