Skip to content

Optimize logger string formatting to avoid repeated allocations #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

Optimize logger string formatting to avoid repeated allocations #670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0fe9bd
Initial plan
Copilot Oct 31, 2025
adc1fd0
Refactor logger to use stringstream directly, avoiding inefficient st…
Copilot Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/include/logger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,19 +92,20 @@ class Logger {
std::array<std::string, sizeof...(args)> argStrings = {toStringHelper(std::forward<Args>(args))...};

std::stringstream ss;
std::string formattedHeader = header_;
size_t argIndex = 0;
size_t pos = 0;

// Replace "%@" placeholders
while ((pos = formattedHeader.find("%@", pos)) != std::string::npos && argIndex < argStrings.size()) {
formattedHeader.replace(pos, 2, argStrings[argIndex]);
pos += argStrings[argIndex].length();
++argIndex;
// Replace "%@" placeholders by iterating through header_
for (size_t i = 0; i < header_.size(); ++i) {
if (i + 1 < header_.size() && header_[i] == '%' && header_[i + 1] == '@' &&
argIndex < argStrings.size()) {
ss << argStrings[argIndex];
++argIndex;
++i; // Skip the '@' character
} else {
ss << header_[i];
}
}

ss << formattedHeader;

// Append remaining arguments
for (size_t i = argIndex; i < argStrings.size(); ++i) {
if (delimiter_) {
Expand Down