Support Synchronous Initialization for Proxy Service

[caiomcbr]

No description provided.

[Copilot]

Pull Request Overview

This PR adds support for synchronous initialization of the proxy service by introducing a mechanism to wait for the proxy thread to fully start and initialize before proceeding. This ensures that operations depending on the proxy being ready can safely proceed.

• Adds a new isStarted() method to Proxy and ProxyService classes that blocks until the proxy thread has started
• Introduces an atomic_bool threadStarted flag to track the proxy thread initialization state
• Integrates the synchronous wait in the Executor initialization to ensure the proxy is ready before use

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/proxy.cc	Adds threadStarted flag and isStarted() method implementing busy-wait synchronization
include/mscclpp/proxy.hpp	Declares new isStarted() method in Proxy class
src/port_channel.cc	Adds isStarted() wrapper method in ProxyService
include/mscclpp/port_channel.hpp	Declares new isStarted() method in ProxyService class
src/executor/executor.cc	Calls isStarted() after starting proxy to ensure initialization completes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@caiomcbr I've opened a new pull request, #681, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/proxy.cc:49

• The new blocking parameter is used in executor.cc but there is no test coverage for the blocking behavior of Proxy::start(). Consider adding a test that verifies the proxy thread is fully initialized after start(true) returns, similar to the existing proxy tests in test/unit/local_channel_tests.cu or test/mp_unit/port_channel_tests.cu.

  auto initFunc = [cudaDevice, deviceNumaNode]() {
    MSCCLPP_CUDATHROW(cudaSetDevice(cudaDevice));
    if (deviceNumaNode >= 0) {
      numaBind(deviceNumaNode);
    }
  };

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.