Refactor data type handling to use mscclpp::DataType enum #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
intandncclDataType_tparameters with strongly-typedmscclpp::DataTypeenum throughout the API to improve type safety and reduce ambiguity.Changes
DataTypeenum ingpu_data_types.hppwith standard GPU data types (Int8, Uint8, Int32, Uint32, Int64, Uint64, Float16, Float32, BFloat16)AllReduce,AllGather,AllToAll,ReduceScatter) to acceptDataTypeinstead ofintncclDataTypeToMscclpp()conversion inapps/nccl/src/datatype_conversion.hppwithgetDataTypeSize()helpermscclppDataTypetype alias ingpu.hppfor device-side usageExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.