Skip to content

Conversation

@caiomcbr
Copy link
Contributor

@caiomcbr caiomcbr commented Nov 18, 2025

Fix #675

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "DSL Quick Start" guide to help users get started with the MSCCL++ Domain Specific Language for defining custom collective communication algorithms. The guide includes a complete AllGather example with detailed explanations of key concepts like collectives, ranks, buffers, channels, and synchronization patterns.

  • Adds comprehensive DSL Quick Start documentation with a worked example
  • Includes step-by-step explanations of DSL concepts and API usage
  • Provides testing instructions using executor_test.py
  • Integrates the new guide into the documentation index and table of contents

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
docs/index.rst Adds DSL Quick Start entry to the documentation index and table of contents
docs/dsl_quick_start.md New comprehensive guide introducing DSL basics through an AllGather example with installation, usage, and testing instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@caiomcbr caiomcbr requested a review from Copilot November 19, 2025 00:18
Copilot finished reviewing on behalf of caiomcbr November 19, 2025 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@caiomcbr caiomcbr requested a review from Copilot November 20, 2025 00:53
Copilot finished reviewing on behalf of caiomcbr November 20, 2025 00:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use https://github.com/executablebooks/MyST-NB to make sure our code is valid in future.

@caiomcbr caiomcbr requested a review from Binyang2014 November 21, 2025 21:54
@caiomcbr caiomcbr merged commit 17247cd into main Nov 21, 2025
7 checks passed
@caiomcbr caiomcbr deleted the caiorocha/dsl_quick_start branch November 21, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] End-to-End Example for Python DSL for Different Channels

4 participants