-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[QNN EP] Enable v81 devices #26341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QNN EP] Enable v81 devices #26341
Conversation
* Include v81 stub/skel/cat files in build artifacts. * Disable tests that are broken on v79 and v81.
...d/github/azure-pipelines/templates/c-api-artifacts-package-and-publish-steps-windows-qnn.yml
Show resolved
Hide resolved
|
/azp run Windows ARM64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
was v81 support only added in a recent version of the QNN SDK? if so, should we attempt to keep supporting building with older SDK versions or just increase the minimum required SDK version? |
Based on what I know, I think bumping the minimum required version is the way to go. A hard build failure is preferable to accidentally incomplete packages. Given that there isn't any testing of this repo or its build products on real Qualcomm devices, such an error would likely go undetected during the release process (similar to the 1.22.2 wheels reverting to x64 from ARM64x). Of course we test on real hardware on our internal fork, but the packaging parts of the build are not shared. An alternative is to make more parts of the build aware of what's in the various QNN versions, but this further complicates an already complicated system. This is especially challenging/risky because I can't test any of the affected code. What I do not know are the consequences for you of raising the minimum version other than having to revert two changes instead of one if the latest QNN version ends up needing to be yanked. If they're dire, I would be happy to investigate a more complex change. |
this sounds good to me. could we make it an explicit hard failure with a clear error message? e.g., static_assert(QNN_API_VERSION_MAJOR > 2 ||
(QNN_API_VERSION_MAJOR == 2 && QNN_API_VERSION_MINOR >= <required minor version>),
"Minimum required QNN SDK version is ...") |
* Add static_assert to explicitly check that QAIRT 2.39+ in use.
Great idea, @edgchen1. Done. |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
### Description This change adds support for the latest Qualcomm NPUs with the v81 architecture. Specifically: * Include v81 stub/skel/cat files in build artifacts. * Disable tests that are broken on v79 and v81.
Description
This change adds support for the latest Qualcomm NPUs with the v81 architecture.
Specifically: