[EP API] Check for out-of-range node in EpGraph::IndexToEpNodeMap::GetEpNode #26373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tEpNode. Check whether given `node_index` is within the target range of nodes during `EpGraph::IndexToEpNodeMap::GetEpNode`. Since EpGraph may be created from a subset of nodes, it should be checked that queried node is inside current EpGraph. While operating on partitioned graphs, SegFault occurrs if tries to acquire a node that is partitioned to another EpGraph (i.e., different EP).
minfhong-qti
changed the title
|
Hi @edgchen1, |
@adrianlizarraga mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check whether given
node_indexis within the target range of nodes duringEpGraph::IndexToEpNodeMap::GetEpNode. Since EpGraph may be created from a subset of nodes, it should be checked that queried node is inside current EpGraph.Motivation and Context
While operating on partitioned graphs, SegFault occurrs if tries to acquire a node that is partitioned to another EpGraph (i.e., different EP).