-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WebNN] Correct behavior of Softmax < opset 13 #26391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ONNX Softmax operates with different semantics before and after opset 13.
Before opset 13, it normalizes over the flattened range of dimensions
starting from axis to the last dimension. Fix it by reshaping the input
to [M, N] where M = prod(d0..d{axis-1}) and N = prod(d{axis-1}..d{n-1})
and apply softmax along N, then reshaping back to the original shape.
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run MacOS CI Pipeline / iphone_simulator (arm64) |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 One minor comment, but LGTM.
onnxruntime/core/providers/webnn/builders/impl/softmax_op_builder.cc
Outdated
Show resolved
Hide resolved
|
Restarting Windows GPU TensorRT test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline |
|
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline |
|
/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI |
|
/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Test Linux CUDA x64 Release,Test Linux TensorRT x64 Release,web_Debug / build_onnxruntime_web,web_Release / build_onnxruntime_web |
|
/azp run Linux QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hmm, infrastructure issue it appears. Will retry tomorrow. |
ONNX Softmax operates with different semantics before and after opset 13. Before opset 13, it normalizes over the flattened range of dimensions starting from axis to the last dimension. Fix it by reshaping the input to [M, N] where M = prod(d0..d{axis-1}) and N = prod(d{axis-1}..d{n-1}) and applying softmax along N, then reshaping back to the original shape.