webgpu: add MatMul and Gemm cases with large shapes #26572
+431
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The PR add cases for #26433 and #26461 @jchen10 @Jiawei-Shao PTAL |
jchen10
reviewed
Nov 14, 2025
| } | ||
|
|
||
| TEST(MatMul_Large, Float16_Subgroup) { | ||
| RunTestTyped<float, 13>({512, 1024}, {1024, 1024}); |
jchen10
reviewed
Nov 14, 2025
| } | ||
|
|
||
| } // namespace test | ||
| } // namespace onnxruntime |
Contributor
There was a problem hiding this comment.
Too many duplicated code lines between the Float32 and Float16 cases. You can have one case covering both Float32 and Float16.
Split_Dim_Inner and Subgroup are not good names for the cases. They don't help me understand the rationale behind the tested various shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context