Fix build dependencies #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Maven build dependencies to improve dependency management across the semantic-kernel project. The changes consolidate common dependencies at parent module levels and standardize version management.
- Moved common dependencies to parent POMs to reduce duplication
- Added missing semantic-kernel-data-postgres dependency to the BOM
- Updated PMD plugin version from 3.21.2 to 3.27.0
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| semantickernel-bom/pom.xml | Added semantic-kernel-data-postgres dependency to BOM |
| semantickernel-api/pom.xml | Removed explicit phase configuration from maven dependency plugin |
| samples/semantickernel-sample-plugins/pom.xml | Added common semantic-kernel dependencies |
| samples/semantickernel-learn-resources/pom.xml | Removed explicit version declarations and added API dependencies |
| samples/semantickernel-demos/sk-presidio-sample/pom.xml | Removed dependencies that are now inherited from parent |
| samples/semantickernel-demos/semantickernel-spring-starter/pom.xml | Removed dependencies that are now inherited from parent |
| samples/semantickernel-demos/pom.xml | Added common semantic-kernel dependencies |
| samples/semantickernel-demos/booking-agent-m365/pom.xml | Removed dependencies that are now inherited from parent |
| samples/semantickernel-concepts/semantickernel-syntax-examples/pom.xml | Added multiple semantic-kernel API dependencies |
| pom.xml | Updated PMD plugin version and added dependency management entries |
| api-test/pom.xml | Added common semantic-kernel dependencies and spotless plugin version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist