fix: implicitly mark discriminated model types as dynamic #8933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
requested review from
JoshLove-msft,
christothes,
jsquire and
m-nash
as code owners
Collaborator
|
You can try these changes here
|
jorgerangel-msft
force-pushed
the
fix-base-dynamicmodel
branch
3 times, most recently
from
bf2840b to
33e4b90
Compare
jorgerangel-msft
changed the title
...rp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Models/DynamicModelWithBase.cs
Show resolved
Hide resolved
jorgerangel-msft
commented
Nov 5, 2025
| } | ||
| //base.JsonModelWriteCore(writer, options); | ||
| #pragma warning disable SCME0001 // Type is for evaluation purposes only and is subject to change or removal in future updates. | ||
| if (Optional.IsDefined(Name) && !Patch.Contains("$.name"u8)) |
Contributor
Author
There was a problem hiding this comment.
this needs to be generated
jorgerangel-msft
commented
Nov 5, 2025
| id = prop.Value.GetString(); | ||
| continue; | ||
| } | ||
| patch.Set([.. "$."u8, .. Encoding.UTF8.GetBytes(prop.Name)], prop.Value.GetUtf8Bytes()); |
Contributor
Author
There was a problem hiding this comment.
this needs to be generated
jorgerangel-msft
commented
Nov 5, 2025
...rp/generator/TestProjects/Local/Sample-TypeSpec/src/Generated/Models/DynamicModelWithBase.cs
Show resolved
Hide resolved
jorgerangel-msft
force-pushed
the
fix-base-dynamicmodel
branch
from
33e4b90 to
ec9095c
Compare
jorgerangel-msft
force-pushed
the
fix-base-dynamicmodel
branch
from
ec9095c to
23bd60e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8926