[typespec-vscode] fix singature help test super slow #8996
+98
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
RodgeFu
reviewed
Nov 13, 2025
RodgeFu
reviewed
Nov 14, 2025
RodgeFu
reviewed
Nov 14, 2025
RodgeFu
reviewed
Nov 17, 2025
RodgeFu
reviewed
Nov 17, 2025
RodgeFu
reviewed
Nov 17, 2025
.chronus/changes/fix-signature-help-test-slow-2025-10-14-2-25-10.md
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Nov 20, 2025
mzhongl524
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
RodgeFu
reviewed
Nov 20, 2025
| const promise = freshUpdateManager.scheduleUpdate(document, "changed"); | ||
|
|
||
| // Verify that promise is created (indicating adaptive delay is being used) | ||
| expect(promise).toBeInstanceOf(Promise); |
Contributor
There was a problem hiding this comment.
please verify the delay for the different scenarios.
| return this.#cachedDebounceDelay; | ||
| } | ||
|
|
||
| const delayOverride = process.env[UPDATE_MANAGER_DEBOUNCE_DELAY_OVERRIDE]; |
Member
There was a problem hiding this comment.
this breaks the playground, do not reference process anywhere that is not the cli or the server startup script
Member
There was a problem hiding this comment.
can the server host not contain this config instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8960.
Fix singature help test super slow.