-
Notifications
You must be signed in to change notification settings - Fork 38
feat: fix for Pylint(W1514:unspecified-encoding)
#608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: fix for Pylint(W1514:unspecified-encoding)
#608
Conversation
| "too-many-positional-arguments", | ||
| "too-many-branches", | ||
| "too-many-instance-attributes", | ||
| "unspecified-encoding", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this removal, tests fail with
> assert_that(len(diagnostics), is_(greater_than(0)))
E AssertionError:
E Expected: a value greater than <0>
E but: was <0>
src/test/python_tests/test_code_actions.py:406: AssertionError
------------------------------------------------------------------------------------------ Captured log call ------------------------------------------------------------------------------------------
ERROR concurrent.futures:_base.py:344 exception calling callback for <Future at 0x729661915600 state=finished returned NoneType>
Without this changeScreencast.from.04-28-2025.09.10.45.PM.webm |
With this changeScreencast.from.04-28-2025.08.57.49.PM.webm |
|
@karthiknadig are there any changes you'd like me to make here? |
|
@eleanorjboyd are there any changes you'd like me to make here? |
karthiknadig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a few more cases:
open(path, 'r', newline='\n') => open(path, 'r', encoding='utf-8', newline='\n')
cases for multi line open:
open(
path,
'r'
)
open(
path,
'r',
newline='\n',
)
Closes #607