SCM - more improvements to the repositories view #274438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SCM Repositories view to handle artifact icons separately from labels, and adds new Git commands for creating branches and tags directly from artifact groups.
- Separates icon rendering from label text in artifact and artifact group renderers
- Improves tree compression logic to handle artifacts and folders correctly
- Adds new
git.repositories.createBranchandgit.repositories.createTagcommands
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts | Separates icon HTML elements from IconLabel components, updates rendering logic to use ThemeIcon.asClassName, improves tree compression and expansion logic |
| src/vs/workbench/contrib/scm/browser/media/scm.css | Adds icon margin styling and removes unused container flex display rule |
| extensions/git/src/commands.ts | Refactors tag creation into reusable _createTag method and adds new artifact group command handlers |
| extensions/git/package.json | Adds new git.repositories commands and updates menu contributions to use them instead of generic commands |
| import { ICompressibleTreeRenderer } from '../../../../base/browser/ui/tree/objectTree.js'; | ||
| import { ICompressedTreeNode } from '../../../../base/browser/ui/tree/compressedObjectTreeModel.js'; | ||
| import { ITreeCompressionDelegate } from '../../../../base/browser/ui/tree/asyncDataTree.js'; | ||
| import { Codicon } from '../../../../base/common/codicons.js'; |
There was a problem hiding this comment.
[nitpick] The Codicon import is only used for Codicon.folder. Consider using a more specific import or verify if ThemeIcon already provides folder icon constants that would be more consistent with the existing icon handling pattern in this file.
src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.