fix: add duplicate detection for reference list properties #57
+65
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add uniqueArray() utility function to validate array uniqueness with detailed error messages - Apply uniqueness validation to all _refs properties (object_marking_refs, x_mitre_tactic_refs, x_mitre_analytic_refs) - Update detection-strategy test expectations to align with new duplicate prevention behavior - Add support for new ATT&CK v18 SDO types (x-mitre-analytic, x-mitre-detection-strategy) in test data validation The uniqueArray() function uses Zod v4's check() method to report which specific values are duplicated, improving developer experience when validation fails. Reference list properties now properly enforce uniqueness constraints, preventing duplicate embedded relationships in STIX objects.
Contributor
Author
|
Closes #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uniqueArray()utility function using Zod v4'scheck()method for array uniqueness validation*_refssuffix):object_marking_refsx_mitre_tactic_refsx_mitre_analytic_refsx-mitre-analytic,x-mitre-detection-strategy) in test dataThe
uniqueArray()function provides detailed error messages that specify which values are duplicated, improving the debugging experience. This prevents duplicate embedded relationships in STIX objects, ensuring data integrity across all reference properties.Test plan
uniqueArray()function correctly identifies and reports duplicate values*_refsproperties enforce uniqueness constraints