Skip to content

Conversation

@thomasjpfan
Copy link
Contributor

@thomasjpfan thomasjpfan commented Sep 19, 2025

Describe your changes

Fixes https://linear.app/modal-labs/issue/SDK-612/gpu-fallback-functions-arent-identified-as-web-endpoints-on-deploy

Checklists

Compatibility checklist

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Release checklist

If you intend for this commit to trigger a full release to PyPI, please ensure that the following steps have been taken:

  • Version file (modal_version/__init__.py) has been updated with the next logical version
  • Changelog has been cleaned up and given an appropriate subhead

[!NOTE]
Use web URL from handle metadata when reporting function creation and add a test to verify it’s displayed.

  • Function creation status:
    • Use response.handle_metadata.web_url when displaying created web function URL; continue printing warnings, proxy auth suffix, suffix from web_url_info, and custom domains.
  • Tests:
    • Add test_url_displayed_function_create_status_web_url to verify the web URL from handle metadata is printed in the finish message.

Written by Cursor Bugbot for commit f8b52be. This will update automatically on new commits. Configure here.

@freider
Copy link
Contributor

freider commented Sep 19, 2025

Lets add some tests for this too (I had claude do that earlier today but they weren't very good)

@thomasjpfan
Copy link
Contributor Author

I added a unit test for FunctionCreationStatus specifically for web_url.

@thomasjpfan
Copy link
Contributor Author

@prbot approve

@modal-pr-review-automation
Copy link

Please request a reviewer to follow up with a post-merge review.

Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasjpfan thomasjpfan merged commit 8dafd62 into main Nov 7, 2025
28 checks passed
@thomasjpfan thomasjpfan deleted the thomasjpfan/use_handle_metadata_web_url branch November 7, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants