Skip to content

Conversation

@eggag32
Copy link
Contributor

@eggag32 eggag32 commented Oct 28, 2025

Adds a nonpreemptible boolean to SchedulerPlacement in modal_proto/api.proto.

This SchedulerPlacement is part of the function definition and is how the client indicates the Function's containers should be scheduled onto nonpreemptible instances.

Checklists

Compatibility checklist

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

[!NOTE]
Adds a nonpreemptible boolean to SchedulerPlacement in modal_proto/api.proto.

  • Proto definitions:
    • modal_proto/api.proto:
      • SchedulerPlacement: add boolean field nonpreemptible (= 6).

Written by Cursor Bugbot for commit 4f03312. This will update automatically on new commits. Configure here.

@devennavani devennavani force-pushed the egor/nonpreemptible-proto branch from 4f03312 to 91667da Compare November 8, 2025 05:38
@devennavani devennavani changed the title [SVC-803] Add nonpreemptible field to SchedulerPlacement proto [SVC-803 1/N] Add nonpreemptible field to SchedulerPlacement proto Nov 8, 2025
@devennavani
Copy link
Contributor

@prbot approve @mwaskom

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwaskom mwaskom merged commit 5608d89 into main Nov 8, 2025
27 checks passed
@mwaskom mwaskom deleted the egor/nonpreemptible-proto branch November 8, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants