Use an async version of create_connection in flash healtcheck #3698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This async function used
socket.create_connectionwhich is blocking. This PR introduces an async version ofsocket.create_connectionwith ``async.create_connection` and uses that instead.Checklists
Compatibility checklist
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Release checklist
If you intend for this commit to trigger a full release to PyPI, please ensure that the following steps have been taken:
modal_version/__init__.py) has been updated with the next logical versionNote
Introduce an async port-check helper and replace the blocking socket check in Flash heartbeat with asyncio-based connectivity checks, adding targeted tests.
modal/_utils/async_utils.py):is_port_connection_open(host, port, timeout)usingasyncio.open_connection.modal/experimental/flash.py):is_port_connection_openin_FlashManager.is_port_connection_healthyinstead of blockingsocket.create_connection.asyncio.TimeoutError.test/async_utils_test.py):test_is_port_connection_openandtest_is_port_connection_open_failure.Written by Cursor Bugbot for commit 0d52553. This will update automatically on new commits. Configure here.