Skip to content

Conversation

@mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Nov 5, 2025

Closes SDK-639


Note

Propagates app tags into AppCreate for run/deploy by plumbing tags through init paths and updates tests to assert tags on AppCreate.

  • runner:
    • Include tags in AppCreateRequest by updating _init_local_app_new(description, tags, ...) and _init_local_app_from_name(name, tags, ...) to accept/pass tags.
    • run path: capture local_app_state early and pass local_app_state.tags to _init_local_app_new.
    • deploy path: capture local_app_state early; pass local_app_state.tags to _init_local_app_from_name; consistently pass local_app_state to _create_all_objects/_publish_app.
  • tests:
    • test_tags: now asserts AppCreate request includes tags in addition to AppPublish.

Written by Cursor Bugbot for commit f5a69e0. This will update automatically on new commits. Configure here.

Changelog

  • Fixed a bug where App tags were not attached to Image builds that occur when running or first deploying the App.

@mwaskom mwaskom requested a review from thomasjpfan November 5, 2025 21:39
@mwaskom mwaskom merged commit 57a165f into main Nov 6, 2025
28 checks passed
@mwaskom mwaskom deleted the michael/2025-11-05-app-create-tags branch November 6, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants