Add support for SEP-1330 Elicitation Enums #952
+378
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows the DynamicJsonForm to render the various enum types supported by the new version of the spec (SEP-1330).
Changes Made
In DynamicJsonForm.tsx,
oneOf/anyOfwith{ const, title }enumenumNamesfor labelsitems.anyOf/oneOfitems.enumtitlefor object field labels; fall back to the JSON key when missing.minItems/maxItemshelper text when present.In schemaUtils.ts
generateDefaultValuenow includes optional properties that declare adefault, ensuring fields like strings show their defaults on first render.In jsonUtils.ts
enumNames?: string[]and array constraintsminItems?/maxItems?.Type of Change
Related Issues
#933
Testing
Test Results and/or Instructions
Used this PR for the Everything server which updates it Elicitation Request to have all the fields.
Checklist
npm run prettier-fix)Breaking Changes
Nope.
Additional Context
For more on the various enum types now supported by the protocol, see SEP-1330