Update Server to always send response to invalid messages
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyhan
pushed a commit
to devyhan/swift-sdk
that referenced
this pull request
Apr 4, 2025
dcherrera
added a commit
to dcherrera/swift-sdk
that referenced
this pull request
Nov 5, 2025
…om response handlers - Removed await logger?.trace() from handleResponse() (lines 689-692) - Removed await logger?.trace() from handleMessage() (lines 716-719) - Removed await logger?.trace() from handleBatchResponse() (lines 762-763) These calls were causing 10-second actor boundary crossing delays when processing tool call responses, causing callTool() to appear to hang. Replaced with NSLog() for immediate, non-blocking logging. This fixes the final blocker preventing MCP tool execution from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.