Skip to content

Conversation

@wille
Copy link

@wille wille commented Nov 13, 2025

Motivation and Context

Any errors in route handles or middlewares like errors in a user provided clientStore or user provided OAuthServerProvider will quietly be swallowed, stopping users of this library from properly debugging their implementation and stopping users from debugging mcp clients and implementing their own error handling.

It's unlikely that the user wants to do provide their own error responses so I'm not modifying that, this change solely throws errors to be picked up by the express error handler

How Has This Been Tested?

I'm doing a lot of MCP related OAuth stuff right now and this is the biggest blocker from me using this library.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@wille wille requested a review from a team as a code owner November 13, 2025 14:15
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@1107

commit: 80c9737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant