Passthrough removal part 2: Achieve 0 passthrough types. #1125
+152
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
KKonstantinov
changed the title
9 tasks
Contributor
Author
|
Converting to draft - in favour of working towards merging #1040 first - to avoid further overhead of migrating to zod v4. Will follow up with this after we merge zod v4, if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to achieve 0 passthrough on zod types.
Motivation and Context
Passthrough was largely removed in another PR, but a few still remain.
This PR aims to remove any remaining .passthrough() from the SDK.
How Has This Been Tested?
Unit tests.
Breaking Changes
None. Bringing SDK back to full spec compliance.
Types of changes
Checklist