-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: implement SEP-1699 SSE polling via server-side disconnect #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixweinberger
wants to merge
11
commits into
main
Choose a base branch
from
fweinberger/sep-1699
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+510
−29
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
464b1f8
feat: implement SEP-1699 SSE polling via server-side disconnect
felixweinberger c1d581a
Add test for replaying multiple messages after closeSSEStream
felixweinberger 6d32c15
Allow multiple GET streams for resuming different POST streams
felixweinberger 8f6701e
feat: add GET stream polling support for SEP-1699
felixweinberger 78d116f
chore: remove SEP-1699 references from test comments
felixweinberger 8469a85
Merge branch 'main' into fweinberger/sep-1699
felixweinberger 55b9e30
Remove standalone GET stream polling features
felixweinberger 7cbfb78
Add getStreamIdForEventId to InMemoryEventStore
felixweinberger 0ad8154
Keep backwards compatible EventStore behavior
felixweinberger c16b5f5
fix(test): correct taskResumability test to use GET-based resumption
felixweinberger 2516b88
Merge main and resolve conflict in streamableHttp.ts
felixweinberger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this test to use
GETfor resumption as required by the spec: https://modelcontextprotocol.io/specification/2025-06-18/basic/transports#resumability-and-redeliverycc: @mattzcarey as we chatted about this weirdness between POST & GET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels weird to have to send a notification to resume the stream...wouldn't it make sense to have a specific method to resume?