Ps/frontend fixes #177
Draft
Ps/frontend fixes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 5f56318 - view on LGTM.com new alerts:
fixed alerts:
|
asfaltboy
force-pushed
the
ps/119/fix-null-field
branch
from
65a91f8 to
f1fe314
Compare
|
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 65a91f8 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 43f3503 - view on LGTM.com new alerts:
fixed alerts:
|
+ update code to use v4
+ simplify inline tabular classes
add an empty form, only if not submitting and extras required
asfaltboy
force-pushed
the
ps/frontend-fixes
branch
from
59540fb to
59544cd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // options added from the backend need to be removed | ||
| elm.find("option").remove(); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Semicolon insertion
| } | ||
| }, | ||
| _getCloseBtn = function(type) { | ||
| if(type !== _currPopupType || !mfp.currTemplate.closeBtn) { |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin
| // remove scrollbar, add margin e.t.c | ||
| $('html').css(windowStyles); | ||
|
|
||
| // add everything to DOM |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin
| // allows to modify markup | ||
| _mfpTrigger('FirstMarkupParse', markup); | ||
|
|
||
| if(markup) { |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #169
fix #38