Skip to content

Conversation

@FGasper
Copy link
Contributor

@FGasper FGasper commented Sep 10, 2025

No description provided.

@FGasper FGasper requested a review from a team as a code owner September 10, 2025 18:06
@FGasper FGasper requested a review from addaleax September 11, 2025 13:00
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need to have some sort of triage conversation in the team here, we don't typically add this type of feature on a very ad-hoc basis but this does make sense to me to add in general

FGasper and others added 2 commits September 11, 2025 10:46
Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: Anna Henningsen <[email protected]>
@FGasper
Copy link
Contributor Author

FGasper commented Sep 11, 2025

@addaleax Triage: by all means. I just wanted to PoC the idea to get the ball rolling.

@addaleax addaleax changed the title Add a download script to facilitate easy use in CI. feat: add a download script to facilitate easy use in CI MONGOSH-2687 Sep 11, 2025
@FGasper FGasper requested a review from addaleax September 12, 2025 13:33
esac

jq_query=$(cat <<EOF
.versions[0].downloads[] |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really do a semver comparison here, right? Otherwise I think that would be highly preferable.

If we leave this as-is, I'd leave a comment in

currentVersions.sort((a, b) => semver.rcompare(a.version, b.version));
about this script depending on that specific ordering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(@addaleax added the comment since jQ is a funky—if poetic, heh—place to do things like semver sorting.)

push:
branches:
- main
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to have this run every day etc. as a health check?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagik Sure: 2a71d49

@addaleax addaleax requested review from gagik and lerouxb December 11, 2025 17:08
Copy link
Contributor

@lerouxb lerouxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pretty useful!

@addaleax addaleax merged commit a7f68dc into mongodb-js:main Dec 14, 2025
152 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants