Skip to content

Conversation

@kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Dec 11, 2025

No description provided.

@kmruiz kmruiz self-assigned this Dec 11, 2025
Copilot AI review requested due to automatic review settings December 11, 2025 15:37
@kmruiz kmruiz requested a review from a team as a code owner December 11, 2025 15:37
We want to see if we can compile Kerberos in 2.x before
attempting the update to 7.0.0
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the kerberos package dependency in the service provider node driver package. However, there is a critical discrepancy between the PR title and the actual implementation.

Key Changes:

  • Updates kerberos from version 2.1.0 to 2.2.2 (NOT 7.0.0 as indicated in the title)
  • Updates the dependency in both dependencies and optionalDependencies sections for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kmruiz kmruiz force-pushed the feat/update-kerberos branch from 5f85418 to 1b1839e Compare December 11, 2025 15:40
@addaleax addaleax changed the title feat: Update Kerberos to 7.0.0 MONGOSH-1881 chore(deps): bump kerberos to 2.2.2 MONGOSH-1881 Dec 11, 2025
@kmruiz kmruiz requested a review from addaleax December 11, 2025 16:45
@kmruiz
Copy link
Contributor Author

kmruiz commented Dec 11, 2025

The e2e tests, smoke tests and packaging for Windows is working fine. For other OSes, most of them are passing, unless the ones that depend on GitHub for downloading dependencies. It's safe to merge.

@kmruiz kmruiz merged commit ca4f8b8 into main Dec 11, 2025
110 of 121 checks passed
@kmruiz kmruiz deleted the feat/update-kerberos branch December 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants