LG-5446: CodeEditor QA Fixes #3261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: abf02e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +1.79 kB (+0.11%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
…o view after actions
…ent unstyled render
…r rendering control and optimize extension return with useMemo for performance
…hanced testing capabilities
…styles and package configuration
adamrasheed
approved these changes
Oct 30, 2025
Collaborator
adamrasheed
left a comment
adamrasheed
left a comment
There was a problem hiding this comment.
Quite a chunky PR but I'll approve it this time
sandynguyenn
approved these changes
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
packages/code-editor/src/CodeEditor/hooks/extensions/useReadOnlyExtension.spec.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Oct 30, 2025
packages/code-editor/src/CodeEditor/hooks/extensions/useCodeFoldingExtension.tsx
Show resolved
Hide resolved
shaneeza
reviewed
Oct 30, 2025
packages/code-editor/src/CodeEditor/hooks/extensions/useThemeExtension.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
| <CodeEditor.Panel | ||
| title="Test Panel" | ||
| innerContent={ | ||
| <div data-testid={PANEL_TEST_ID}>Test Panel Content</div> |
Collaborator
There was a problem hiding this comment.
nit: don't we have test utils to get the panel?
Collaborator
Author
There was a problem hiding this comment.
Good call, will update
shaneeza
reviewed
Oct 30, 2025
shaneeza
reviewed
Oct 30, 2025
| * Since the editor is created in a separate effect without extensions, it is created before the extensions | ||
| * are applied. This prevents a blink of an unstyled editor. | ||
| */ | ||
| const rafId = requestAnimationFrame(() => { |
Collaborator
There was a problem hiding this comment.
Will the extensions always be rendered after the next frame?
Collaborator
Author
There was a problem hiding this comment.
That's a good question. We have an extensionsInitialized prop that technically isn't set until after the extensions are dispatched, and this prevents showing the editor until true. My original thought was that this is all that would be needed, but it didn't work. So the theory at least is that there must be a small race condition and this prevents it. I'm not sure of a better way to handle it, but would be open to ideas.
Collaborator
There was a problem hiding this comment.
My original thought was that this is all that would be needed, but it didn't work.
So you were trying to set setExtensionsInitialized without requestAnimationFrame but that wasn't working?
Collaborator
Author
There was a problem hiding this comment.
Correct, you still saw just a blink of non-styled content
Collaborator
There was a problem hiding this comment.
Using requestAnimationFrame doesn't seem reliable, but I also don't have a solution. Does the dispatch on the line above initialize the extensions? Could there be a case where the extensions don't initialize but it will still be set to true because of requestAnimationFrame?
Collaborator
Author
That's a good point! Let's disable them all. Will update |
Contributor
|
Coverage after merging LG-5446/ce-qa into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
shaneeza
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR fixes a number of bugs and missed features that were found in QA.
Bugs that were found in QA can be found in the CodeEditor QA Issue Log. This PR fixes the following:
Additional drive-by fixes:
CodeEditor.specby:CodeEditor.specfor core functionalityCodeEditor.ImperativeHandle.specfor testing the imperative handle functionalitySearchPanel.specfor testing search functionalitypreloadedModules. This makes the tests more straight forward to reason with since it removes any loading🎟️ Jira ticket: LG-5446
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes