MONGOID-5757 Fix validation checks so that all associated records are validated #5881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously stopping at the first failed validation.
comandeo-mongo
approved these changes
Oct 14, 2024
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Oct 14, 2024
…ongodb#5881) It was previously stopping at the first failed validation.
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Oct 14, 2024
…ongodb#5881) It was previously stopping at the first failed validation.
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Oct 14, 2024
…ongodb#5881) It was previously stopping at the first failed validation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made for MONGOID-5704 introduced a regression that caused associated validations to stop after the first failure, rather than validating all associated records. This PR corrects the regression by fixing the short-circuited evaluation that was introduced in that earlier PR.