Skip to content

MONGOID 5800 When initializing an embedded association with an invalid hash, got undefined method `with_indifferent_access' error #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleburgess2025 merged 9 commits into from
Dec 17, 2025
+24 −1
Merged

MONGOID 5800 When initializing an embedded association with an invalid hash, got undefined method `with_indifferent_access' error #6075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60c3236
Adds support for single hash input in nested attributes for has_many …
kyleburgess2025 Dec 12, 2025
6b7d9bb
Adding a check to initialize()
kyleburgess2025 Dec 12, 2025
4b62cd6
add with_indifferent_access to array
kyleburgess2025 Dec 12, 2025
8d417bb
fixing how we handle arrays
kyleburgess2025 Dec 12, 2025
e61cbd2
empty commit
kyleburgess2025 Dec 12, 2025
d7099a5
Merge branch 'master' into MONGOID-5800
kyleburgess2025 Dec 12, 2025
2647510
adding more guards in build()
kyleburgess2025 Dec 12, 2025
bef124d
Merge branch 'MONGOID-5800' of https://github.com/kyleburgess2025/mon…
kyleburgess2025 Dec 12, 2025
82b5786
Adding handling for if the array has uneven number of elements
kyleburgess2025 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/mongoid/association/nested/many.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ class Many
# This attempts to perform 3 operations, either one of an update of
# the existing association, a replacement of the association with a new
# document, or a removal of the association.
#
# It raises an argument error if the attributes are not a Hash or an
# Array of key/value pairs.
#
# @example Build the nested attrs.
# many.build(person)
Expand All @@ -32,8 +35,12 @@ def build(parent, options = {})
attributes.each do |attrs|
if attrs.is_a?(::Hash)
process_attributes(parent, attrs.with_indifferent_access)
else
elsif attrs.is_a?(Array) && attrs.length > 1 && attrs[1].respond_to?(:with_indifferent_access)
process_attributes(parent, attrs[1].with_indifferent_access)
elsif attrs.is_a?(Array) && attrs.length.even?
process_attributes(parent, Hash[*attrs].with_indifferent_access)
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Hash[*attrs] assumes attrs is an array with an even number of elements (key-value pairs). If attrs has an odd number of elements, this will raise an ArgumentError. Add validation or rescue logic to handle malformed input gracefully.

Suggested change
process_attributes(parent, Hash[*attrs].with_indifferent_access)
if attrs.respond_to?(:to_a) && attrs.to_a.length.even?
process_attributes(parent, Hash[*attrs].with_indifferent_access)
else
# Malformed input: skip or handle as needed
# Optionally, log a warning here
next
end

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@kyleburgess2025 kyleburgess2025 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need more guards here in case it can't be cast to a hash?

Copy link
Contributor

@jamis jamis Dec 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably smart to check that array has an even number of elements, before creating a hash from it. I think an empty Hash is okay here -- I can imagine someone doing Person.new(children: {}) (thus creating a new person with a single child).

We should probably also raise an exception in the final else clause, so that we never have data being silently ignored. A simple ArgumentError would probably suffice, indicating that the arguments aren't supported or something.

Copy link
Contributor Author

@kyleburgess2025 kyleburgess2025 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - I didn't add any extra testing for this, I can't think of any scenarios where an uneven number of fields would be provided, but I agree that it's a good thing to check for.

else
raise ArgumentError, "Attributes for nested association '#{association.name}' must be a Hash or an Array of key/value pairs."
end
end
end
Expand Down
16 changes: 16 additions & 0 deletions spec/integration/associations/embeds_many_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,4 +327,20 @@ class Comment
end
end
end

context "when a hash is provided instead of an array for an embeds_many association" do
let(:post) { EmbedsManySpec::Post.new(title: 'Broken post', comments: { content: 'Comment' }) }

it "does not raise an error on initialization" do
expect { post }.to_not raise_error
end

it "does not raise an error when accessing the association" do
expect { post.comments }.to_not raise_error
end

it "allows building new documents on the association" do
expect(post.comments.build).to be_a EmbedsManySpec::Comment
end
end
end
Loading