Fix documentation inaccuracies about C API error handling #3407
+41
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Documentation incorrectly claimed the C API layer implements an "exception firewall" with try-catch blocks and defensive null checks. Code inspection revealed the C API is a minimal pass-through wrapper with no exception handling.
Corrections Made:
Error handling claims: Removed all references to "exception firewall" and defensive null checks
if (!canvas || !paint) return;defensive checksArchitecture descriptions: Updated layer responsibility descriptions
Files Updated:
AGENTS.mddesign/architecture-overview.mddesign/QUICKSTART.mddesign/README.mddesign/adding-new-apis.mddesign/error-handling.md.github/instructions/README.mdVerified Accurate:
Bugs Fixed
None. Documentation-only changes.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.