This repository was archived by the owner on Aug 22, 2023. It is now read-only.
dont use 'git:github.com' protocol #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Sep 2, 2022
| [submodule "external/libgit2"] | ||
| path = external/libgit2 | ||
| url = git://github.com/mono/libgit2.git | ||
| url = https://www.github.com/mono/libgit2.git |
There was a problem hiding this comment.
This will make it use the same protocol as the parent repository was cloned with, so I think that's a better alternative here.
Suggested change
| url = https://www.github.com/mono/libgit2.git | |
| url = ../mono/libgit2.git |
|
Git currently restricts cloning to https only and redirects http to https
so I think https is good enough
And I don't think ssh cloning can be used since requires password for ssh
key
…On Sat, 3 Sep 2022, 4:08 am Marius Ungureanu, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitmodules
<#2 (comment)>:
> @@ -1,7 +1,7 @@
[submodule "external/libgit2"]
path = external/libgit2
- url = git://github.com/mono/libgit2.git
+ url = https://www.github.com/mono/libgit2.git
This will make it use the same protocol as the parent repository was
cloned with, so I think that's a better alternative here.
⬇️ Suggested change
- url = https://www.github.com/mono/libgit2.git
+ url = ../mono/libgit2.git
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLITH2YWPLEFU7JDOCMTOLV4I7B3ANCNFSM57VMG42A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.