Bugfix FXIOS-14375 DefaultURLFormatter not handling urls properly for < iOS 17 #31209
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
force-pushed
the
cc/FXIOS-14375_investigate-urlformatter-tests
branch
from
ab9b5be to
9f6f3b5
Compare
cyndichin
commented
Dec 10, 2025
Comment on lines
104
to
114
| /** | ||
| Returns whether the URL's scheme is one of those listed on the official list of URI schemes. | ||
| This only accepts permanent schemes: historical and provisional schemes are not accepted. | ||
| */ | ||
| public func schemeIsValid(for url: URL) -> Bool { | ||
| guard let scheme = url.scheme else { return false } | ||
| return SchemesDefinition.permanentURISchemes.contains(scheme.lowercased()) | ||
| && url.absoluteString.lowercased() != scheme + ":" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Copied over from our schemeIsValid code in our URL extension
cyndichin
force-pushed
the
cc/FXIOS-14375_investigate-urlformatter-tests
branch
from
9f6f3b5 to
49f01d3
Compare
Contributor
Author
|
Note: This was the only similar PR I found - #26101 Seems like we handled percent encoding in the past but not specifically mentioning iOS 17 change under the hood. |
💪 Quality guardian1 tests files modified. You're a champion of test coverage! 🚀 🧹 Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Generated by 🚫 Danger Swift against cb28ce5 |
lmarceau
reviewed
Dec 12, 2025
lmarceau
approved these changes
Dec 12, 2025
Contributor
lmarceau
left a comment
lmarceau
left a comment
There was a problem hiding this comment.
Small comment otherwise LGTM
Co-authored-by: lmarceau <[email protected]>
Contributor
|
🚀 PR merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This test
testGetURLGivenAboutConfigSpaceURLThenValidEscapedURLwas failing for versions < iOS 17. This is because Apple changed howURL(string: xxx)works under the hood. The test was failing forabout: configbecause it was returningnilinstead ofabout:%20config. This is due to older versions not automatically adding the percent encoding, see more details in the doc: https://developer.apple.com/documentation/foundation/url/init(string:)Note: The URLFormatted is currently not being used and discussed with @lmarceau that we eventually want to use the new
DefaultURLFormatterbut has not been prioritized. For now, we will add a fix specifically for iOS 17 and we revert the fix that was merged as part of this PR.cc: @yoanarios
📝 Checklist