Add FXIOS-14446 [Performance] Make all states equatable #31278
Conversation
|
🚀 |
🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 ✅ Per-file coverageAll changed files meet the threshold of 35.0%. Client.app: Coverage: 37.12
Redux: Coverage: 92.26
Generated by 🚫 Danger Swift against 0ede11b |
| // State was updated but observers are not notified if the state is the same | ||
| guard newState != oldState else { | ||
| return | ||
| } |
There was a problem hiding this comment.
@mattreaganmozilla I was thinking it could be good to have a log here at least in the beginning for debugging purposes but I am not sure if it is overkill or going to be weird to pass the logger to this level.
There was a problem hiding this comment.
Honestly I think that would create too much spam in the console. 🤔 I had worked on a logger throttler for de-dup'ing messages a while back but never merged it (pretty sure this is the PR: #22547).
We could consider rolling that back in perhaps, it would probably help in scenarios like this.
📜 Tickets
Jira ticket
💡 Description
Make
StateTypeprotocol equatable and all descending States equatable🎥 Demos
Demo
📝 Checklist