Skip to content

Conversation

@Foxbolts
Copy link
Collaborator

@Foxbolts Foxbolts commented Dec 12, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add the privacy notice homepage cell component

📝 Technical Notes:

  • This is just the homepage cell, without any presentation or action logic (not currently presented anywhere in the app)
  • ⚠️ Still awaiting UX feedback regarding the tappable size of the close button

🎥 Demos

Screenshots
Screenshots
Simulator Screenshot - iPhone 17 - 2025-12-12 at 16 03 51
Simulator Screenshot - iPhone 17 - 2025-12-12 at 16 03 55
Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-12-12 at 16 06 15
Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-12-12 at 16 06 18
Simulator Screenshot - iPhone 17 - 2025-12-12 at 16 42 47

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@Foxbolts Foxbolts requested a review from a team as a code owner December 12, 2025 21:25
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 12, 2025

Messages
📖 Project coverage: 37.72%

🧹 Tidy commit

Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
firefox-ios/Client/Frontend/Home/Homepage/PrivacyNotice/PrivacyNoticeCell.swift 0.0% 35.0%
BrowserKit/Sources/Shared/SupportUtils.swift 0.0% 35.0%

Client.app: Coverage: 37.09

File Coverage
PrivacyNoticeCell.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 7e35b94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants