Extract Lang attribute for marked contents #20407
Open
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixteman
reviewed
Oct 30, 2025
test/unit/api_spec.js
Outdated
| const pdfDoc = await loadingTask.promise; | ||
| const pdfPage = await pdfDoc.getPage(1); | ||
|
|
||
| pdfDoc.annotationStorage.setValue("30R", { value: "test" }); |
Contributor
There was a problem hiding this comment.
There is no annotations in the pdf so I don't see the point of setting these values.
Contributor
Author
There was a problem hiding this comment.
Uh I am sorry, bad copy/paste from a previous test. Removed
calixteman
reviewed
Oct 30, 2025
| const opList = await pdfPage.getOperatorList({ | ||
| annotationMode: AnnotationMode.DISABLE, | ||
| }); | ||
| expect(opList.fnArray[0]).toEqual(OPS.beginMarkedContentProps); |
Contributor
There was a problem hiding this comment.
Why is it useful to get the lang parameter in the operator list which is used to draw the pdf ?
calixteman
reviewed
Oct 30, 2025
Contributor
|
Could you rebase your patch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some marked contents have a
Langattribute defined in the props passed to thebeginMarkedContentPropsoperator. With this PR, the evaluator extracts this information. I chose to pass thepropsobject as third argument in order to maintain backwards compatibility, but I'm open to changes.