Skip to content

Fix infinite loop in JBIG2 decoder with >4 referred-to segments #20440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −13
Open

Fix infinite loop in JBIG2 decoder with >4 referred-to segments #20440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/jbig2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,15 +1165,15 @@ function readSegmentHeader(data, start) {
let referredToCount = (referredFlags >> 5) & 7;
const retainBits = [referredFlags & 31];
let position = start + 6;
if (referredFlags === 7) {
if (referredToCount === 7) {
referredToCount = readUint32(data, position - 1) & 0x1fffffff;
position += 3;
let bytes = (referredToCount + 7) >> 3;
let bytes = (referredToCount + 8) >> 3;
retainBits[0] = data[position++];
while (--bytes > 0) {
retainBits.push(data[position++]);
}
} else if (referredFlags === 5 || referredFlags === 6) {
} else if (referredToCount === 5 || referredToCount === 6) {
throw new Jbig2Error("invalid referred-to flags");
}

Expand Down
1 change: 1 addition & 0 deletions test/pdfs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,7 @@
!comments.pdf
!issue20319_1.pdf
!issue20319_2.pdf
!issue20439.pdf
!bug1992868.pdf
!bug1937438_af_from_latex.pdf
!bug1937438_from_word.pdf
Expand Down
Binary file added test/pdfs/issue20439.pdf
View file
Open in desktop
Binary file not shown.
17 changes: 7 additions & 10 deletions test/test_manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,16 +1114,6 @@
"lastPage": 1,
"type": "eq"
},
{
"id": "hmm-pdf",
"file": "pdfs/hmm.pdf",
"md5": "e08467e60101ee5f4a59716e86db6dc9",
"link": true,
"rounds": 1,
"firstPage": 1,
"lastPage": 2,
"type": "load"
},
{
"id": "issue7847_radial",
"file": "pdfs/issue7847_radial.pdf",
Expand Down Expand Up @@ -2809,6 +2799,13 @@
"rounds": 1,
"type": "eq"
},
{
"id": "issue20439",
"file": "pdfs/issue20439.pdf",
"md5": "3c7e888b26ff00943ec1610d93235efc",
"rounds": 1,
"type": "eq"
},
{
"id": "issue15942",
"file": "pdfs/issue15942.pdf",
Expand Down