Skip to content

Slightly reduce the memory used by thumbnails #20462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

Slightly reduce the memory used by thumbnails #20462

merged 1 commit into from
Nov 29, 2025
+102 −114

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Nov 25, 2025

In using a blob instead of a base64 string it's possible to reduce the memory. And simplify a bit the thumbnails themselves.

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 27, 2025

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 27, 2025

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/b54b3fb841358c7/output.txt

timvandermeij
timvandermeij approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and passing integration tests. Thanks!

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 27, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b54b3fb841358c7/output.txt

Total script time: 0.99 mins

Published

timvandermeij
timvandermeij reviewed Nov 27, 2025
View reviewed changes
@calixteman
Copy link
Contributor Author

calixteman commented Nov 28, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 28, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f834886026e6846/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 28, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e32c0614c6d9f8f/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 28, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f834886026e6846/output.txt

Total script time: 20.75 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 28, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e32c0614c6d9f8f/output.txt

Total script time: 40.95 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and the integration test error fixed.

@calixteman
Slightly reduce the memory used by thumbnails
423379e 
In using a blob instead of a base64 string it's possible to reduce the memory.
And simplify a bit the thumbnails themselves.
@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 29, 2025

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3b8b971d38b3269/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3b8b971d38b3269/output.txt

Total script time: 0.99 mins

Published

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 29, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/62d3f4f42a937b5/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/67980fb706eb8ea/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/67980fb706eb8ea/output.txt

Total script time: 20.53 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 29, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/62d3f4f42a937b5/output.txt

Total script time: 41.01 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit f44e5f0 into mozilla:master Nov 29, 2025
7 checks passed
@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 29, 2025

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

viewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @timvandermeij @moz-tools-bot