Skip to content

Conversation

@querielo
Copy link
Contributor

@querielo querielo commented Nov 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 4, 2025 17:01
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.14
86.33
355.14
86.33
+0 B
+0 B
WebGPU 609.62
170.99
609.62
170.99
+0 B
+0 B
WebGPU Nodes 608.23
170.72
608.23
170.72
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 486.77
121.07
486.77
121.07
+0 B
+0 B
WebGPU 678.47
186.28
678.47
186.28
+0 B
+0 B
WebGPU Nodes 620.47
169.54
620.47
169.54
+0 B
+0 B

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects documentation for the optimize() method in the BatchedMesh class by removing an incorrect parameter description that doesn't match the method signature.

Key changes:

  • Removed erroneous @param documentation for a non-existent instanceId parameter in the optimize() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mugen87 Mugen87 added this to the r182 milestone Nov 4, 2025
@Mugen87 Mugen87 merged commit 2eefcd6 into mrdoob:dev Nov 4, 2025
16 checks passed
@Mugen87 Mugen87 changed the title Remove unused parameter from optimize method in BatchedMesh class BatchedMesh: Remove unused parameter from optimize() docs. Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants